Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyState - Move EmptyStateHeader into EmptyState #550

Closed
wise-king-sullyman opened this issue Jan 17, 2024 · 0 comments · Fixed by #582
Closed

EmptyState - Move EmptyStateHeader into EmptyState #550

wise-king-sullyman opened this issue Jan 17, 2024 · 0 comments · Fixed by #582
Assignees
Labels

Comments

@wise-king-sullyman
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#9947

We moved the EmptyStateHeader and EmptyStateIcon sub-components of EmptyState to be built into EmptyState and controlled by props rather than passed in composably.

As part of that change we also made the titleText prop required.

This codemod should move props from EmptyStateHeader and EmptyStateIcon to EmptyState as needed, then remove the EmptyStateHeader and EmptyStateIcon component usage and imports.

If a titleText is not available and we can't figure out a way of autogenerating one based on child content passed to the heading before we should flag the missing titleText as an issue requiring manual intervention.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@wise-king-sullyman wise-king-sullyman self-assigned this Jan 17, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 17, 2024
@tlabaj tlabaj added the codemod label Feb 14, 2024
@tlabaj tlabaj added this to the Penta alpha release milestone Feb 14, 2024
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Not started in PatternFly Issues Feb 14, 2024
@wise-king-sullyman wise-king-sullyman moved this from Not started to In Progress in PatternFly Issues Feb 16, 2024
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Feb 20, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants