Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Button - aria-disabled is false when button is disabled #11462

Open
nicolethoen opened this issue Jan 23, 2025 · 1 comment · May be fixed by #11478
Open

Bug - Button - aria-disabled is false when button is disabled #11462

nicolethoen opened this issue Jan 23, 2025 · 1 comment · May be fixed by #11478
Assignees
@thatblindgeye
Labels
A11y
Milestone
2025.Q1

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Jan 23, 2025 •
edited
Loading

In the Button component In both cases (disabled or enabled) aria-disabled is always false.

From @thatblindgeye: "It probably doesnt do any harm when the button is enabled but we still don’t need it… Since it’s probably been an issue for however long it probably wouldn’t hurt much more if they just wait for us to provide a fix, which we could try to get in for this milestone"

Image

Image

reported during the OCP + PF6 migration
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 23, 2025
@redjhawk
Copy link

FYI, on Patternfly v5.4 it worked properly. I have some tests reading aria-disabled on a wizard footer and it all passed.

@thatblindgeye thatblindgeye self-assigned this Jan 24, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to PR Review in PatternFly Issues Jan 24, 2025
@thatblindgeye thatblindgeye added this to the 2025.Q1 milestone Jan 24, 2025
@thatblindgeye thatblindgeye linked a pull request Jan 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
A11y
Projects
PatternFly Issues
Status: PR Review
Milestone
2025.Q1
Development

Successfully merging a pull request may close this issue.

fix(Button): updated rendering of aria-disabled attribute thatblindgeye/patternfly-react
3 participants
@redjhawk @nicolethoen @thatblindgeye