Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2020-7608 #262

Closed
Hyperkid123 opened this issue Oct 10, 2023 · 2 comments · Fixed by #266
Closed

CVE-2020-7608 #262

Hyperkid123 opened this issue Oct 10, 2023 · 2 comments · Fixed by #266

Comments

@Hyperkid123
Copy link
Contributor

GHSA-p9pc-299p-vxgp

The package showdown has an old yargs-parser dependency with this critical security vulnerability. Can we update the dependencies to remove it?

@jessiehuff jessiehuff added this to the QS Prioritized Backlog milestone Oct 11, 2023
@jessiehuff jessiehuff moved this from Needs triage to Not started in PatternFly Extensions Oct 11, 2023
@dgutride
Copy link
Member

This one is important for us, too - @jessiehuff

@jschuler
Copy link
Collaborator

If you're still on PF4:
https://www.npmjs.com/package/@patternfly/quickstarts/v/2.4.3

If you're on PF5:
https://www.npmjs.com/package/@patternfly/quickstarts/v/5.1.0

In either case, showdown is no longer declared a dependency, it continue to remain a peer dependency though.
So in your own project, make sure that showdown is at 2.1.0 or greater.

i.e.
https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/package.json#L75
https://github.com/openshift/console/blob/master/frontend/package.json#L220
Could be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants