Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version prefix to tokens #11

Open
srambach opened this issue Jan 5, 2024 · 1 comment
Open

Add version prefix to tokens #11

srambach opened this issue Jan 5, 2024 · 1 comment
Labels
Core followup Needs follow-up in core

Comments

@srambach
Copy link
Member

srambach commented Jan 5, 2024

We'll want to version the tokens for coordinating any breaking changes with core. Version will be a design-tokens version, not the core version. (However, we will have a mapping of what versions work together, e.g. design-tokens v1 works with core v6)

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 5, 2024
@srambach srambach added this to the 2024.Q1 milestone Jan 23, 2024
@kmcfaul kmcfaul modified the milestones: 2024.Q1, Penta alpha release Mar 12, 2024
@srambach srambach moved this from Needs triage to Ready to assign in PatternFly Issues Mar 20, 2024
@srambach srambach added PF6 Core followup Needs follow-up in core labels Apr 5, 2024
@mcoker
Copy link
Contributor

mcoker commented Jun 12, 2024

Notes from a discussion with @nicolethoen @srambach

The proposed plan is currently:

  • Since we technically won't need a version in the token string until we need to implement a new version, we're going to hold off on adding a version for the time being, and when we need to add a new version, we'll start at v2
  • Implied above with v2 and the issue description, but we confirmed the token version does not need to match the version of PF component classes/vars. Eg, maybe PF-v6/v7/v8 all use --pf-t--global if there are no breaking changes to tokens, and PF-v9 uses --pf-t--v2--global
    • Random related point, we're thinking that (for the most part) a breaking change to tokens will necessitate a breaking change to anything that consumes tokens, but breaking changes to things that consume tokens do not need to cause a breaking change in tokens or otherwise need to iterate/change token versions.
  • Consider a unique version identifier in the string other than v[n] for token versions, to make it clear it's not the same as or tied to a major version of PF. Eg, something like --pf-t-2--global
  • We can reconvene on the entire approach after v6/tokens release and we learn more about stuff like how they're used, what kinds of changes we're wanting to make to tokens,

@srambach srambach moved this from Ready to assign to Parking lot in PatternFly Issues Jun 18, 2024
@srambach srambach removed this from the Penta beta release milestone Jun 18, 2024
@srambach srambach removed the PF6 label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core followup Needs follow-up in core
Projects
Status: Parking lot
Development

No branches or pull requests

3 participants