Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The brand/title element in the header shifts based on surrounding elements #324

Open
asuwebdesign opened this issue Nov 18, 2024 · 2 comments
Labels
PF6 Applies to only the PF6 version
Milestone

Comments

@asuwebdesign
Copy link
Collaborator

In the header, the contents before and after the brand/title element (middle section) can negatively impact the composition. The brand/title element should remain centered in the header regardless of its surrounding content.

For product use, we are using the technology icon for the brand element. Ideally, this icon never shifts away from the absolute center position. Attaching a screenshot for reference.

Image

@asuwebdesign asuwebdesign added the PF6 Applies to only the PF6 version label Nov 18, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 18, 2024
@rebeccaalpert
Copy link
Member

The fact that anyone can put whatever they want in here makes it hard to force it into the center. We can probably add a prop for a grid layout if we know there's N number of options, but we should probably keep the flex layout as an option as well.

@rebeccaalpert rebeccaalpert added this to the 2024.Q4 milestone Nov 18, 2024
@rebeccaalpert rebeccaalpert moved this from Needs triage to Not started in PatternFly Issues Nov 18, 2024
@rebeccaalpert rebeccaalpert self-assigned this Nov 18, 2024
@rebeccaalpert
Copy link
Member

rebeccaalpert commented Nov 25, 2024

I took a look at this and we're using a grid layout here already.

What they can do as a workaround is apply a custom class to the title component with position: absolute; left: 0; width: 100%. I think it's unlikely that we want to ship an absolute positioned logo as part of the extension because consumers can put any logo they want and any content they want. There's no way to control for it working in every context, and we'll get a lot of bug reports about it.

There are other ways to accomplish this, like using the image as a background image, but we would need to know the logo in advance (and its width), which is likewise impossible in this context.

I think this may be outside of the scope of what we can provide given that we have no control over image sizes, what goes in the header, etc. However, I did confirm that everything in the header accepts outside classes, so products can customize this as needed for their use case.

I'd like to bring this up for discussion at our weekly meeting - you're more than welcome to attend. I'll close this or not based on the outcome of that call.

@rebeccaalpert rebeccaalpert moved this from In Progress to Not started in PatternFly Issues Nov 25, 2024
@rebeccaalpert rebeccaalpert moved this from Not started to Parking lot in PatternFly Issues Nov 25, 2024
@rebeccaalpert rebeccaalpert modified the milestones: 2024.Q4, 2025.Q1 Dec 2, 2024
@rebeccaalpert rebeccaalpert moved this from Parking lot to Not started in PatternFly Issues Jan 6, 2025
@rebeccaalpert rebeccaalpert removed their assignment Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF6 Applies to only the PF6 version
Projects
Status: Not started
Development

No branches or pull requests

2 participants