Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Generation Options #10

Open
2 tasks done
parsehex opened this issue Jan 6, 2024 · 2 comments
Open
2 tasks done

Return Generation Options #10

parsehex opened this issue Jan 6, 2024 · 2 comments

Comments

@parsehex
Copy link
Owner

parsehex commented Jan 6, 2024

Need to return the exact generation parameters passed to the model so that client can be accurate.

At least for LLMs and Img AI, maybe for TTS but doesn't seem necessary for STT (maybe if we ever add another client).

  • Update Pydantic models
  • Return correct results from clients, managers and routes
  • Anything else?
@parsehex
Copy link
Owner Author

parsehex commented Jan 6, 2024

I don't think it's necessary to return the info object as a string, needing to parse the JSON.

@parsehex
Copy link
Owner Author

parsehex commented Jan 6, 2024

Didn't test thoroughly but it seems like this is in, for LLMs and Img. Do need to change Img param "info" -> "params" for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant