Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused analysis reexports #124

Closed
juangirini opened this issue Aug 23, 2023 · 1 comment
Closed

Remove unused analysis reexports #124

juangirini opened this issue Aug 23, 2023 · 1 comment
Assignees
@juangirini
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@juangirini
Copy link
Contributor

The issue #172 has undercover some unused reexports.
The following reexports seem to be unused
https://github.com/paritytech/substrate/blob/b7c18f1f5c9dc5c4ffa683e230303f084efe82cb/frame/benchmarking/src/lib.rs#L32-L33

We need to double check that and remove that along with the associated dead code.
@juangirini juangirini mentioned this issue Aug 23, 2023
Merged
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@juangirini juangirini moved this from Backlog to In Progress in Runtime / FRAME Aug 28, 2023
@juangirini juangirini self-assigned this Aug 28, 2023
@juangirini
Copy link
Contributor Author

@ggwpez this actually is being used in benchmarking-cli

@juangirini juangirini closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Aug 29, 2023
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @bkchr
Bump jsonrpc-core from 14.1.0 to 14.2.0 (paritytech#124)
e0510a5
claravanstaden added a commit to claravanstaden/polkadot-sdk that referenced this issue Sep 19, 2024
@claravanstaden @vgeddes
Adds finalized header gap check (paritytech#124)
8be52c9 
* adds finalized header gap check

* fix comment

* fmt

* use constant for max gap

* remove redundant config

* fmt

* fix tests

* fix again

* fmt

* test works

* revert change

* Update bridges/snowbridge/pallets/ethereum-client/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* fmt

---------

Co-authored-by: claravanstaden <Cats 4 life!>
Co-authored-by: Vincent Geddes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juangirini juangirini

Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juangirini @the-right-joyce