-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rlp - test failures on 32-bit #802
Comments
Fabian-Gruenbichler
added a commit
to Fabian-Gruenbichler/parity-common
that referenced
this issue
Dec 16, 2023
the overflow behaviour depends on the width of usize, conditionalize accordingly. Fixes: paritytech#802 Signed-off-by: Fabian Grünbichler <[email protected]>
patch from #808 works according to Debian CI: https://ci.debian.net/packages/r/rust-rlp/testing/i386/ alternatively, the condition could also be using usize::BITS directly, feel free to adapt as you see fit - the input values should be valid for whichever check you choose ;) |
ordian
added a commit
that referenced
this issue
Jan 2, 2024
the overflow behaviour depends on the width of usize, conditionalize accordingly. Fixes: #802 Signed-off-by: Fabian Grünbichler <[email protected]> Co-authored-by: ordian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Debian CI is reporting test failures for the rlp crate on 32-bit architectures. The tests in question expect errors and get errors, but the errors received are not the ones expected.
The text was updated successfully, but these errors were encountered: