Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AT Error on Consensus trait #13237

Closed
Tracked by #13238
emhane opened this issue Dec 9, 2024 · 2 comments · Fixed by #13655
Closed
Tracked by #13238

AT Error on Consensus trait #13237

emhane opened this issue Dec 9, 2024 · 2 comments · Fixed by #13655
Assignees
@chungquantin
Labels
A-consensus Related to the consensus engine A-sdk Related to reth's use as a library S-needs-design This issue requires design work to think about how it would best be accomplished

Comments

@emhane
Copy link
Member

emhane commented Dec 9, 2024

Describe the feature

Return Self::Error instead of ConsensusError type in Consensus trait methods. This makes it possible for rollups to configure custom errors (where one variant wraps the l1 ConsensusError type).

Additional context

No response
@emhane emhane added A-consensus Related to the consensus engine A-sdk Related to reth's use as a library S-needs-design This issue requires design work to think about how it would best be accomplished labels Dec 9, 2024
@emhane emhane mentioned this issue Dec 9, 2024
Open
@chungquantin
Copy link
Contributor

Is this available? Can I work on it?

@chungquantin chungquantin mentioned this issue Jan 4, 2025
Merged
@chungquantin
Copy link
Contributor

Ready for review: #13655

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chungquantin chungquantin

Labels
A-consensus Related to the consensus engine A-sdk Related to reth's use as a library S-needs-design This issue requires design work to think about how it would best be accomplished
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Consensus trait error type chungquantin/reth
2 participants
@chungquantin @emhane