Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic data primitives BlockExecutionStrategyFactory #12947

Closed
Tracked by #12358
emhane opened this issue Nov 28, 2024 · 1 comment
Closed
Tracked by #12358

Generic data primitives BlockExecutionStrategyFactory #12947

emhane opened this issue Nov 28, 2024 · 1 comment
Labels
A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain

Comments

@emhane
Copy link
Member

emhane commented Nov 28, 2024

Describe the feature

Make BlockExecutionStrategyFactory generic over data primitives

/// A strategy factory that can create block execution strategies.
pub trait BlockExecutionStrategyFactory: Send + Sync + Clone + Unpin + 'static {
/// Associated strategy type.
type Strategy<DB: Database<Error: Into<ProviderError> + Display>>: BlockExecutionStrategy<
DB,
Error = BlockExecutionError,
>;
/// Creates a strategy using the give database.
fn create_strategy<DB>(&self, db: DB) -> Self::Strategy<DB>
where
DB: Database<Error: Into<ProviderError> + Display>;
}

Additional context

No response

@emhane emhane added A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain labels Nov 28, 2024
@Rjected
Copy link
Member

Rjected commented Nov 29, 2024

fixed by #12994

@Rjected Rjected closed this as completed Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants