Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sessions over websocket is not supported #173

Open
npradeep357 opened this issue Nov 12, 2021 · 2 comments
Open

Multiple sessions over websocket is not supported #173

npradeep357 opened this issue Nov 12, 2021 · 2 comments

Comments

@npradeep357
Copy link

When multiple sessions are created through websockets (when started server in ws mode), It is currently only supporting one web socket connection session. According to websockets protocol, it should support multiple connection sessions.

When a second session is connected over websockets, it says, Initialization already done (or) feature already registered..

image

It's better to have support for opening multiple connections with separate instance of JEDI implementation.

@pappasam
Copy link
Owner

Hmm, I'm honestly not very familiar with using this language server through web sockets, but I'm glad that you're experimenting with it! I simply took the web sockets interface exposed by pygls and enabled it as an option in jedi-language-server.

Regarding the issue you have raised, I believe pygls's design is limited in that there is a 1:1 relationship between LSP clients and LSP servers, see here. If you'd like support for multiple clients attached to 1 server, I suggest filing an issue with pygls. I'd fully support such an exploration.

@npradeep357
Copy link
Author

npradeep357 commented Nov 22, 2021

pygls issue reference: here

@npradeep357 npradeep357 changed the title Multiple sessions over websocket is not working Multiple sessions over websocket is not supported Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants