PR labels for default module mapping #17402
-
|
The question arose in #17390 about the proper label to select for changes to the default module mapping table in the Python backend. Is it a user-api-change or new feature? Or do we need yet another label? I'm starting this discussion so we can settle this for future PRs of this kind. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
It really is internal, imo. It shouldn't break any existing users because their overrides take precedence over our default. So it's indeed not User API Change. It's also not really a new feature. The only reason I wasn't using internal in the past is that often these PRs come from first-time contributors and I wanted their change to show up in the changelog. But that doesn't seem very sound. We wouldn't do that if they made other types of internal changes like a refactor. And we already give them attribution in our Contributors.md and Slack/Google Group announcements. |
Beta Was this translation helpful? Give feedback.
-
|
I agree. +1 (Can we make this Q&A so we can mark an answer? 😄 ) |
Beta Was this translation helpful? Give feedback.
It really is internal, imo. It shouldn't break any existing users because their overrides take precedence over our default. So it's indeed not User API Change.
It's also not really a new feature.
The only reason I wasn't using internal in the past is that often these PRs come from first-time contributors and I wanted their change to show up in the changelog. But that doesn't seem very sound. We wouldn't do that if they made other types of internal changes like a refactor. And we already give them attribution in our Contributors.md and Slack/Google Group announcements.