BUG: Add fillna at the beginning of _where not to fill NA. #60729 #60772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Jan 23, 2025
|
|
||
| def test_mask_na(): | ||
| # We should not be filling pd.NA. See GH#60729 | ||
| series = Series([None, 1, 2, None, 3, 4, None]) |
There was a problem hiding this comment.
I think this test can be simplified a bit to reduce the number of operations. Maybe something like:
ser = Series([None, 1, 2, None, 3, 4, None], dtype=pd.Int64Dtype())
result = ser.mask(ser <= 2, -99)
expected = Series([None, 1, 2, None, -99, -99, None], dtype=pd.Int64Dtype())
tm.assert_series_equal(result, expected)| @@ -9674,6 +9674,13 @@ def _where( | |||
| if axis is not None: | |||
| axis = self._get_axis_number(axis) | |||
|
|
|||
| # We should not be filling NA. See GH#60729 | |||
There was a problem hiding this comment.
Is this trying to fill missing values when NaN is the missing value indicator? I don't think that is right either - the missing values should propogate for all types. We may just be missing coverage for the NaN case (which should be added to the test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Added fillna at the beginning of _where so that we can fill pd.NA.
Since this is my first PR, please correct me if I'm mistaken. Thanks!