Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated optional transitive recommended pdep restriction #1756

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

wi11dey
Copy link
Contributor

@wi11dey wi11dey commented Dec 24, 2024

Before this PR

Recommended pdeps cannot be optional

After this PR

Recommended pdeps can be optional.

Fixes #1208

Possible downsides?

None

@changelog-app
Copy link

changelog-app bot commented Dec 24, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove outdated optional transitive recommended pdep restriction

Check the box to generate changelog(s)

  • Generate changelog entry

@wi11dey wi11dey changed the title Remove outdated restriction Remove outdated optional transitive recommended pdep restriction Jan 8, 2025
@bulldozer-bot bulldozer-bot bot merged commit 06bc942 into develop Jan 9, 2025
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the wdey/allow-recommended-optional-pdeps branch January 9, 2025 15:19
@autorelease3
Copy link

autorelease3 bot commented Jan 9, 2025

Released 7.70.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a library to mark a dep as optional
3 participants