Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more descriptive error for 429 Errors/errors with no body #1070

Closed
nihalbhatnagar opened this issue Dec 18, 2024 · 0 comments · Fixed by #1082
Closed

Add a more descriptive error for 429 Errors/errors with no body #1070

nihalbhatnagar opened this issue Dec 18, 2024 · 0 comments · Fixed by #1082
Assignees

Comments

@nihalbhatnagar
Copy link
Contributor

When we receive an error response from API Gateway, we try and parse the body of the response. For some errors(specifically a 429), there is no response body, so a call to response.json fails and logs an "Unexpected end of JSON input" error instead of passing on the response. We should ensure we don't swallow the error in this case.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant