Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade causes task dependency resolution failure #611

Open
nickcharles opened this issue Oct 27, 2020 · 1 comment
Open

Upgrade causes task dependency resolution failure #611

nickcharles opened this issue Oct 27, 2020 · 1 comment

Comments

@nickcharles
Copy link

nickcharles commented Oct 27, 2020

Moving here from ticket https://support-jira.p.t/browse/PDS-141249

Originally discussed in slack thread: https://palantir.slack.com/archives/C5MKHTMD4/p1601314980130500

What happened?

Upgrading from GCV 1.25.0 to 1.26.1 causes build failures due to gradle being unable to determine dependencies of some proto generation tasks. Example Circle failure: https://circle.p.b/workflow-run/7c6bd0f8-8265-442e-8969-4e3e9c03770f

@pkoenig10
Copy link
Member

pkoenig10 commented Dec 22, 2020

This is because the protobufToolsLocator_protoc configuration is configured with transitive = false.
https://github.com/google/protobuf-gradle-plugin/blob/371b11483b7b0160098b5395a7219a191b700201/src/main/groovy/com/google/protobuf/gradle/ToolsLocator.groovy#L97

Due to the changes from #557, constraints are no longer applied to configurations with transitive = false.

For more details, see #649.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants