Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a map field to an object results can break compilation #59

Open
maciekf opened this issue Oct 25, 2018 · 1 comment
Open

Adding a map field to an object results can break compilation #59

maciekf opened this issue Oct 25, 2018 · 1 comment

Comments

@maciekf
Copy link

maciekf commented Oct 25, 2018

Steps to reproduce:

  1. Define an object X and release typescript API bindings version 1.1.0.
  2. Start using version 1.1.0 in a client.
  3. Add a map field to object X and release typescript API binding version 1.2.0.
  4. Upgrading bindings version to 1.2.0 in a client produces compilation errors.
@iamdanfox iamdanfox changed the title Adding a map field to an object is not backwards compatible. Adding a map field to an object results can break compilation Oct 25, 2018
@iamdanfox
Copy link
Contributor

Just to be clear - making a change like this is wire-format compatible, but this issue is specifically trying to avoid compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maciekf @iamdanfox