Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Applied ruleset for master branch blocks release process #779

Open
YOU54F opened this issue Feb 13, 2025 · 3 comments
Open

CI - Applied ruleset for master branch blocks release process #779

YOU54F opened this issue Feb 13, 2025 · 3 comments

Comments

@YOU54F
Copy link
Member

YOU54F commented Feb 13, 2025

See https://github.com/pact-foundation/pact_broker/actions/runs/13307341292/job/37161272200

logs

Calculating increment since last release...
  Performing minor release
  2.[11](https://github.com/pact-foundation/pact_broker/actions/runs/13307341292/job/37161272200#step:4:12)3.0
  Generating RELEASE_NOTES.md
  Updating CHANGELOG.md
  [master 4bb820b6] chore(release): version 2.1[13](https://github.com/pact-foundation/pact_broker/actions/runs/13307341292/job/37161272200#step:4:14).0
   2 files changed, 13 insertions(+), 1 deletion(-)
  Releasing gem to Rubygems
  pact_broker 2.113.0 built to pkg/pact_broker-2.113.0.gem.
  Tagged v2.113.0.
  Untagging v2.113.0 due to error.
  rake aborted!
  Running `git push origin refs/heads/master` failed with the following output:
  
  remote: error: GH013: Repository rule violations found for refs/heads/master.        
  remote: Review all repository rules at https://github.com/pact-foundation/pact_broker/rules?ref=refs%2Fheads%2Fmaster        
  remote: 
  remote: - Changes must be made through a pull request.        
  remote: 
  remote: - Required status check "Test completion check" is expected.        
  remote: 
  To https://github.com/pact-foundation/pact_broker
   ! [remote rejected]   master -> master (push declined due to repository rule violations)
  error: failed to push some refs to 'https://github.com/pact-foundation/pact_broker'

will disable for now to allow release to proceed.

edit: disabled temporarily for release and then re-instated. Would be nice for manually triggered releases to use pact-dev automation user, and that user be setup with an exemption role :)

cc: @JP-Ellis

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Feb 13, 2025

Hmm, should it be pushing directly to master? Would it not be better if it created a PR to merge into master to ensure there's a review?

In any case, it should be possible to allow CI to bypass the branch protection rules. Do you know which account is being used?

@YOU54F
Copy link
Member Author

YOU54F commented Feb 13, 2025

i dont think it needs a review, it is simply pushing the changelog and version bump after a release along with the tag

@JP-Ellis
Copy link
Contributor

Do you know which account is being used to push to master? The rules can be configured to exempt this specific user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants