From 21ce787ad13c3c8088f3edc886af3d699c15f15a Mon Sep 17 00:00:00 2001 From: Beth Skurrie Date: Thu, 5 Oct 2023 13:09:13 +1100 Subject: [PATCH] chore: remove the feature toggled buildUrl from the embedded version decorator --- lib/pact_broker/api/decorators/embedded_version_decorator.rb | 3 --- .../approvals/publish_contract_no_branch.approved.json | 1 - .../approvals/publish_contract_nothing_exists.approved.json | 1 - .../publish_contract_nothing_exists_with_webhook.approved.json | 1 - .../publish_contract_verification_already_exists.approved.json | 1 - 5 files changed, 7 deletions(-) diff --git a/lib/pact_broker/api/decorators/embedded_version_decorator.rb b/lib/pact_broker/api/decorators/embedded_version_decorator.rb index 37b444511..849e903eb 100644 --- a/lib/pact_broker/api/decorators/embedded_version_decorator.rb +++ b/lib/pact_broker/api/decorators/embedded_version_decorator.rb @@ -7,9 +7,6 @@ class EmbeddedVersionDecorator < BaseDecorator camelize_property_names property :number - if PactBroker.feature_enabled?(:branches) - property :build_url - end link :self do | options | { diff --git a/spec/fixtures/approvals/publish_contract_no_branch.approved.json b/spec/fixtures/approvals/publish_contract_no_branch.approved.json index 760b54cf2..fa32b6e1b 100644 --- a/spec/fixtures/approvals/publish_contract_no_branch.approved.json +++ b/spec/fixtures/approvals/publish_contract_no_branch.approved.json @@ -119,7 +119,6 @@ }, "version": { "number": "1", - "buildUrl": "http://ci/builds/1234", "_links": { "self": { "title": "Version", diff --git a/spec/fixtures/approvals/publish_contract_nothing_exists.approved.json b/spec/fixtures/approvals/publish_contract_nothing_exists.approved.json index 112a57132..4db446149 100644 --- a/spec/fixtures/approvals/publish_contract_nothing_exists.approved.json +++ b/spec/fixtures/approvals/publish_contract_nothing_exists.approved.json @@ -110,7 +110,6 @@ }, "version": { "number": "1", - "buildUrl": "http://ci/builds/1234", "_links": { "self": { "title": "Version", diff --git a/spec/fixtures/approvals/publish_contract_nothing_exists_with_webhook.approved.json b/spec/fixtures/approvals/publish_contract_nothing_exists_with_webhook.approved.json index 12c0d46da..fc61dca65 100644 --- a/spec/fixtures/approvals/publish_contract_nothing_exists_with_webhook.approved.json +++ b/spec/fixtures/approvals/publish_contract_nothing_exists_with_webhook.approved.json @@ -110,7 +110,6 @@ }, "version": { "number": "1", - "buildUrl": "http://ci/builds/1234", "_links": { "self": { "title": "Version", diff --git a/spec/fixtures/approvals/publish_contract_verification_already_exists.approved.json b/spec/fixtures/approvals/publish_contract_verification_already_exists.approved.json index 1dccd59f5..62ebb0f77 100644 --- a/spec/fixtures/approvals/publish_contract_verification_already_exists.approved.json +++ b/spec/fixtures/approvals/publish_contract_verification_already_exists.approved.json @@ -101,7 +101,6 @@ }, "version": { "number": "1", - "buildUrl": "http://ci/builds/1234", "_links": { "self": { "title": "Version",