Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Tobyfit still supporting only one unique instrument? #917

Open
abuts opened this issue Nov 29, 2022 · 0 comments
Open

Is Tobyfit still supporting only one unique instrument? #917

abuts opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
Discussion Task requiring further discussion Post-Construction

Comments

@abuts
Copy link
Member

abuts commented Nov 29, 2022

get_inst_class function of sqw class used in @sqw/tobyfit and @sqw/resolution_plot and tested in test_sqw_class-->test_migrated_api throws if non-unique instrument is attached to the class.

This is easy changeable, but then what would usage scenario in the places above would be?
The issue should be clarified and fixed.

After discussion with Toby we see that this is not the case and substantial changes in the logic of the methods have to be done.
Single instrument is not sufficient any more.

Need thinking and decision on what is the right thing to be doing if more then one instrument is there.

The equivalent description was found in #902. Those is the duplicate of this one so is closed:
get_inst_class function has been modified after unique object container become the part of experiment. Old implementation was failing when multiple different instruments were identified in the container. I have currently modified it to support this behavior but apparently Tobyfit should support multiple instruments.

How get_inst_class function should be modified to support multiple instruments and do these modifications to the function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Task requiring further discussion Post-Construction
Projects
None yet
Development

No branches or pull requests

4 participants