Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove site specific code from Horace #266

Open
nickbattam-tessella opened this issue Jun 19, 2020 · 0 comments
Open

Remove site specific code from Horace #266

nickbattam-tessella opened this issue Jun 19, 2020 · 0 comments
Labels
CI Build scripts or Jenkins tasks Discussion Task requiring further discussion FileSystem Relating to where files are not their content Low Priority Low Priority Tasks Post-MVP Technical Debt code quality, unit tests, code duplicaton

Comments

@nickbattam-tessella
Copy link
Member

The Horace/Herbert code base includes code paths specifically for the iDAaaS deployment via an is_idaaas() function.

Site-specific code should not be included in the core Horace/Herbert code - this creates a situation where sites other than ISIS have a different deployment and user experience.

Where there are site-specific or machine-class-specific requirements (e.g. temp folder locations) these should managed through configuration data deployed in a consistent method. Configuration in a site-specific configuration file should override the default configuration.

@nickbattam-tessella nickbattam-tessella added the Technical Debt code quality, unit tests, code duplicaton label Jun 19, 2020
@oerc0122 oerc0122 added the FileSystem Relating to where files are not their content label Dec 3, 2020
@oerc0122 oerc0122 added CI Build scripts or Jenkins tasks Post-MVP Discussion Task requiring further discussion labels Jun 20, 2023
@cmarooney-stfc cmarooney-stfc mentioned this issue Sep 16, 2023
12 tasks
@oerc0122 oerc0122 added the Low Priority Low Priority Tasks label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Build scripts or Jenkins tasks Discussion Task requiring further discussion FileSystem Relating to where files are not their content Low Priority Low Priority Tasks Post-MVP Technical Debt code quality, unit tests, code duplicaton
Projects
None yet
Development

No branches or pull requests

2 participants