Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tobyfit_resconv_DG_disk/tobyfit_resconv_DG_fermi do not have unit tests for all possible space of input parameters #1772

Open
abuts opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working Technical Debt code quality, unit tests, code duplicaton

Comments

@abuts
Copy link
Member

abuts commented Nov 13, 2024

Work with Re #1755 have identified that crystal alignment part, related to sqw method refine_crystal_strip_pars have been broken.

While refine_crystal_strip_pars have been formaly fixed under Re #1755, its unclear if the fixture is correct as purpose of the original code is unclear.

The issue is caused by tobyfit_resconv_DG_disk/tobyfit_resconv_DG_fermi method not having unit tests for all possible set of input parameters, including change, caused by refine_crystal_strip_pars usage.

From Re #1755 point of view, I can not even identify what these tests shcould verify. In addition to that, tobyfit_resconv_DG_disk and tobyfit_resconv_DG_fermi have 90% of code in common

These method may contain other errors and common code highly increase the code maintenance cost so the issue should be fixed

@abuts abuts added Technical Debt code quality, unit tests, code duplicaton bug Something isn't working labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Technical Debt code quality, unit tests, code duplicaton
Projects
None yet
Development

No branches or pull requests

1 participant