Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inefficiencies in symmeterize_sqw related to filebacked operations #1354

Open
abuts opened this issue Oct 24, 2023 · 0 comments
Open

Inefficiencies in symmeterize_sqw related to filebacked operations #1354

abuts opened this issue Oct 24, 2023 · 0 comments

Comments

@abuts
Copy link
Member

abuts commented Oct 24, 2023

Current summeterize_sqw algorithm used apply for performing symmetry transformation. This is not a good choice, as symmetry operation moves pixels from its image bins.

To avoid this, all pixels are collated into single bin and this bin is later cut/rebinned into final symmeterized object.

If input data are filebacked data, this would lead to at least two read/write operations over whoule pixel file until the result is achieved.

As symmetry operation is a projection type operation, the symmeterize_sqw should be better implemented through projections, which would allow single path through the whole operation.

Other issue is hash deprecation of old symmeterize_sqw interface. People are widely use it, so it is not diffcult to create new symmetry operation internaly and issue deprecation warning rather then throwing deprecation error.

CM:28.11.23
Low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant