Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current implementation of paging operations in tobyfit_DGdisk_resconv/tobyfit_DGfermi_resconv does not make sence #1348

Open
abuts opened this issue Oct 20, 2023 · 1 comment
Open

current implementation of paging operations in tobyfit_DGdisk_resconv/tobyfit_DGfermi_resconv does not make sence #1348

abuts opened this issue Oct 20, 2023 · 1 comment
Assignees
@oerc0122

Comments

@abuts
Copy link
Member

abuts commented Oct 20, 2023 •
edited by oerc0122
Loading

C.f. #760 for other Tobyfit changes
Blocked by #1340

The code loads all pixels in memory, calculates deviations and then starts assigning the result to filebacked pages.
What the point -- if you can load all pixels in memory, you should not bother with filebacked operations.

Filebacked there either should be removed, or split into pages on much higher level, loading pages and calculating deviations for pages (if it is possible, pixels may go our of current bin with this approach)
@abuts abuts mentioned this issue Oct 20, 2023
Closed
21 tasks
@cmarooney-stfc cmarooney-stfc mentioned this issue Oct 28, 2023
Closed
36 tasks
@oerc0122 oerc0122 mentioned this issue Nov 7, 2023
Closed
@cmarooney-stfc cmarooney-stfc mentioned this issue Nov 15, 2023
Closed
23 tasks
abuts added a commit that referenced this issue Nov 29, 2023
@abuts
Re #1403 remove filebacked from tobyfit_DGdisk_resconv & tobyfit_DGfe…
255206d 
…rmi_resconv Referring to ticket #1348
@abuts abuts mentioned this issue Dec 5, 2023
Merged
oerc0122 added a commit that referenced this issue Dec 13, 2023
@abuts @oerc0122
Reduce get_new_handle usage and disable shift_pixels (#1420)
6d4d8ad 
* Re #1403 Disable shift_pixels. Refer to ticket #962

* Re #1403 remove file-backing from tobyfit_DGdisk_resconv & tobyfit_DGfermi_resconv Refer to ticket #1348

* Re #1403 Remove file-backing from sort_pix. This is part of cut algorithm which works with single block of pixels in memory.

* Raise error in tobyfit if given file-backed data

---------

Co-authored-by: Jacob Wilkins <[email protected]>
@abuts
Copy link
Member Author

abuts commented Jan 18, 2024

Superseeded bu #760 and #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oerc0122 oerc0122

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abuts @oerc0122