Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically determine Q range when using kinematic constraints with euphonic-powder-map #269

Open
ajjackson opened this issue Mar 16, 2023 · 1 comment
Labels
nice to have Not urgently required, but would be an improvement

Comments

@ajjackson
Copy link
Collaborator

Currently I find that when generating kinematically-constrained powder maps the Q range has to be set by trial and error or by looking at the a QECoverage plot from Mantid. I would expect that 95% of the time kinematic constraints are used people will want to see the whole accessible range.

In principle we can calculate this pretty easily, so it might as well be done in the CLI tool if no --q-min or --q-max is set.

Technically that's an API-breaking change to a default setting, but it's hard to see how it would hurt anyone. (There's always a relevant XKCD.)

@ajjackson ajjackson added the nice to have Not urgently required, but would be an improvement label Mar 16, 2023
@mducle
Copy link
Member

mducle commented Mar 16, 2023

The default 0 for --q-min is probably ok. The default of 3 for --q-max is quite arbitrary though and would be nice to change it to match the kinematic constraints if those keywords are given. As for the API breaking... let's see if anyone complains...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have Not urgently required, but would be an improvement
Projects
None yet
Development

No branches or pull requests

2 participants