From 0363dabcc4bb3dc6a882fd01b0686a45ff537715 Mon Sep 17 00:00:00 2001 From: jkskj Date: Wed, 6 Sep 2023 22:09:49 +0800 Subject: [PATCH 1/2] perf: use + instead of strings.Builder --- cmd/interaction/dal/cache/keys.go | 34 ++++--------------------------- 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/cmd/interaction/dal/cache/keys.go b/cmd/interaction/dal/cache/keys.go index c9d91050..a20cae42 100644 --- a/cmd/interaction/dal/cache/keys.go +++ b/cmd/interaction/dal/cache/keys.go @@ -2,8 +2,6 @@ package cache import ( "fmt" - "strings" - "github.com/ozline/tiktok/pkg/constants" ) @@ -18,41 +16,17 @@ func GetUserKey(userID int64) string { } func GetCommentNXKey(videoID string) string { - var builder strings.Builder - builder.Grow(len(constants.CommentNXKey) + 1 + len(videoID)) - builder.WriteString(constants.CommentNXKey) - builder.WriteString(":") - builder.WriteString(videoID) - // return fmt.Sprintf("%s:%s", constants.CommentNXKey, videoID) - return builder.String() + return constants.CommentNXKey + ":" + videoID } func GetCountKey(videoID string) string { - var builder strings.Builder - builder.Grow(len(constants.CountKey) + 1 + len(videoID)) - builder.WriteString(constants.CountKey) - builder.WriteString(":") - builder.WriteString(videoID) - // return fmt.Sprintf("%s:%s", constants.CountKey, videoID) - return builder.String() + return constants.CountKey + ":" + videoID } func GetCommentKey(videoID string) string { - var builder strings.Builder - builder.Grow(len(constants.CommentKey) + 1 + len(videoID)) - builder.WriteString(constants.CommentKey) - builder.WriteString(":") - builder.WriteString(videoID) - // return fmt.Sprintf("%s:%s", constants.CommentKey, videoID) - return builder.String() + return constants.CommentKey + ":" + videoID } func GetCountNXKey(videoID string) string { - var builder strings.Builder - builder.Grow(len(constants.CountNXKey) + 1 + len(videoID)) - builder.WriteString(constants.CountNXKey) - builder.WriteString(":") - builder.WriteString(videoID) - // return fmt.Sprintf("%s:%s", constants.CountNXKey, videoID) - return builder.String() + return constants.CountNXKey + ":" + videoID } From 6c8ec91cbec93a4317f91cbada7ca0bc8235d92a Mon Sep 17 00:00:00 2001 From: jkskj Date: Wed, 6 Sep 2023 22:31:55 +0800 Subject: [PATCH 2/2] style: format the code --- cmd/interaction/dal/cache/keys.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/interaction/dal/cache/keys.go b/cmd/interaction/dal/cache/keys.go index a20cae42..073fec56 100644 --- a/cmd/interaction/dal/cache/keys.go +++ b/cmd/interaction/dal/cache/keys.go @@ -2,6 +2,7 @@ package cache import ( "fmt" + "github.com/ozline/tiktok/pkg/constants" )