Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want implementation of Large Receive Offload #662

Open
FelixMcFelix opened this issue Jan 23, 2025 · 0 comments
Open

Want implementation of Large Receive Offload #662

FelixMcFelix opened this issue Jan 23, 2025 · 0 comments

Comments

@FelixMcFelix
Copy link
Collaborator

FelixMcFelix commented Jan 23, 2025

LRO refers to a host OS or NIC's ability to coalesce multiple packets together, with the aim of reducing the amount of packets processed per second (and delivering larger contiguous data segments to TCP stacks). This can apply to stream transports like TCP, or fragmented UDP reassembly (which is not really applicable on the current dataplane).

Part of the performance boost seen from #614 comes down to the fact that we are abusing the wider underlay MTU to achieve a form of send-side LRO. Fewer packets transit OPTE (eliding identical parse/decision cycles), and fewer packets are handed upstack to guests/zones.

We have some different options here:

  • Attempt optimistic LRO before processing by OPTE. This reduces the cost on packets crossing OPTE (only one parse/process/modify), but when flowstats come around we might need to take some care to prevent the packet_in numbers from surprising customers.
  • Attempt optimistic LRO after processing by OPTE. This has minimal impact on stats

In both cases, illumos zones behave well when served larger packets (i.e., NTP and Nexus zones today) and the setup work for #614 means that viona can always accept and split an oversize/receive-offloaded TCP packet, even if the guest cannot.

This will be blocked on having full packet chain Rx from mac (IPD45).

@FelixMcFelix FelixMcFelix changed the title xde: LRO Want implementation of Large Receive Offload Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant