You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// Datasets on the rack which have been provisioned by RSS.
pubdatasets:Vec<DatasetCreateRequest>,
The Blueprint itself also holds a list of datasets. These should be consistent, but currently aren't: the blueprint only populates address for Crucible datasets, but RSS populates the address for any durable dataset associated with a zone:
At a minimum these should be consistent, but maybe the blueprint has grown to the point where we could remove datasets from the handoff altogether (and let Nexus do what it needs based on the contents of the blueprint)? The same might be true for RackInitializationRequest::{physical_disks,zpools}.
The text was updated successfully, but these errors were encountered:
RSS's handoff to Nexus includes both the initial blueprint:
omicron/nexus/types/src/internal_api/params.rs
Lines 168 to 169 in 390ac60
and a list of datasets to record:
omicron/nexus/types/src/internal_api/params.rs
Lines 177 to 178 in 390ac60
The
Blueprint
itself also holds a list of datasets. These should be consistent, but currently aren't: the blueprint only populatesaddress
for Crucible datasets, but RSS populates the address for any durable dataset associated with a zone:omicron/sled-agent/src/rack_setup/service.rs
Lines 853 to 871 in 390ac60
At a minimum these should be consistent, but maybe the blueprint has grown to the point where we could remove
datasets
from the handoff altogether (and let Nexus do what it needs based on the contents of the blueprint)? The same might be true forRackInitializationRequest::{physical_disks,zpools}
.The text was updated successfully, but these errors were encountered: