From 5581f491bb3cfdd90ed5065cb00d648f5a5cc6ba Mon Sep 17 00:00:00 2001
From: Iskander Sharipov <quasilyte@gmail.com>
Date: Sat, 15 Sep 2018 00:56:22 +0300
Subject: [PATCH] realize: rewrite suspicious append with assignment

The append in form of `a = append(b, ...)` is suspicious
due to mistatching `a` and `b`.

In this particular case, there is a subtle syntax-level
difference due to embedding, but same field is being assigned,
so more "safe" looking code is something like:

	r.Projects = append(r.Projects, Project{exit: make(chan os.Signal, 1)})

But even better, this can be re-written as assignment, without append.
---
 realize/cli_test.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/realize/cli_test.go b/realize/cli_test.go
index 852eaa2..c129c02 100644
--- a/realize/cli_test.go
+++ b/realize/cli_test.go
@@ -11,7 +11,7 @@ import (
 
 func TestRealize_Stop(t *testing.T) {
 	r := Realize{}
-	r.Projects = append(r.Schema.Projects, Project{exit: make(chan os.Signal, 1)})
+	r.Projects = []Project{exit: make(chan os.Signal, 1)}
 	r.Stop()
 	_, ok := <-r.Projects[0].exit
 	if ok != false {