Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions and aliases that must be corrected #796

Closed
3 tasks
Tracked by #779
pabloarosado opened this issue Jan 24, 2023 · 15 comments
Closed
3 tasks
Tracked by #779

Regions and aliases that must be corrected #796

pabloarosado opened this issue Jan 24, 2023 · 15 comments
Assignees
Labels
priority 2 - important wontfix This will not be worked on

Comments

@pabloarosado
Copy link
Contributor

pabloarosado commented Jan 24, 2023

Changes to make

Regions whose name needs to be changed:

  • Turkey -> Türkiye. Should we apply this change? I think so far all our country names are free of accents and umlauts. So this change feels like an outlier.
  • Timor -> Timor-Leste. Since Timor refers to the entire island (where West Timor belongs to Indonesia), but we usually refer to the country East Timor within the island.

Aliases to be corrected:

  • Yemen Arab Republic should be an alias of former region North Yemen, instead of Yemen. I wrote this down some time ago, but I think it has already been fixed. @larsyencken was it you?

Additional changes:

  • We need a short name for "Democratic Republic of Congo", for example for Marimekko charts. What about "DR Congo"?

Todo

  • Countries regions dataset change in ETL
  • Update grapher so that new regions actually show on map
  • Fix every existing country mapping file in ETL
@lucasrodes
Copy link
Member

lucasrodes commented Jan 24, 2023

Turkey -> Türkiye. Should we apply this change? I think so far all our country names are free of accents and umlauts. So this change feels like an outlier.

We can use "Turkiye" instead, but I think we should consider this renaming [ref].

Timor -> Timor-Leste. Since Timor refers to the entire island (where West Timor belongs to Indonesia), but we usually refer to the country East Timor within the island.

An alternative name could be "East Timor".

We need a short name for "Democratic Republic of Congo", for example for Marimekko charts. What about "DR Congo"?

I like it!

@spoonerf
Copy link
Contributor

spoonerf commented Jan 24, 2023

This sounds great and I think we should definitely do it. However, I don't think it is currently possible to use accents in grapher? I made a quick experiment here and the 'ü' doesn't show up.
Screenshot 2023-01-24 at 14 56 45

@edomt
Copy link
Contributor

edomt commented Jan 24, 2023

Thanks Pablo!

I'm a bit hesitant about Turkey – I feel like the new name hasn't "caught on" at all yet. For others like Timor, or past ones like Eswatini, it was very clear we were showing a name that people had stopped using. For Turkey, it seems to me that everyone still calls it "Turkey" (including Wikipedia).

I'm curious to know if others have an opinion about this!

Edit: of course, there's a whole debate about it on Wikipedia.

@Marigold
Copy link
Collaborator

Marigold commented Jan 24, 2023

I'm a bit hesitant about Turkey – I feel like the new name hasn't "caught on" at all yet

(Sorry for chiming in. From my experience changing Czech Republic -> Czechia hasn't caught on either. Organisations and government has only started changing it recently after 6 years of making it official. Residents don't care and even government doesn't seem to care much)

@HannahRitchie
Copy link

My two cents: we shouldn't change Turkey. It's the more commonly-known name.

And until there is a very clear reason and pressure to do so, we shouldn't change country names from the default.

@eoo-owid
Copy link

Agree with Hannah - I understand there are tradeoffs but my view is that the bar for changing country names should be super high. The idea of the OWID standardised names is to go with the most widely known and understandable name, and in the case of Turkiye that's not (yet) the case. Changing country names also break people's code etc. So my vote would be not to change it

@maxroser
Copy link

Very much agree with the high bar for any country name changes.
–> Before we make any change we should discuss among team-leads whether we want to actually make the country name change(s). That's because it has an impact on all teams – from engineering, to product, to writing and data work.

And also agree that we should stick with commonly known country names (i.e. Turkey instead of Türkiye).

@pabloarosado
Copy link
Contributor Author

Thanks everyone! I agree, we don't have to change Turkey for now.
I hope you all agreed on the other suggested changes, and feel free to add any other changes here. I'm planning to implement the changes probably by next week at some point.

@pabloarosado
Copy link
Contributor Author

By the way, just to be clear, nobody was planning to make country name changes any regularly. I just suggested these changes because we are in the middle of a refactor of our countries-regions dataset. Other than that, hopefully, we don't have to make any changes for a long time, so there's no need to worry about it.

@edomt
Copy link
Contributor

edomt commented Jan 25, 2023

@pabloarosado I'll add this to the agenda of tomorrow's team leads meeting, and I'll come back after to confirm.

@edomt
Copy link
Contributor

edomt commented Jan 27, 2023

Hey @pabloarosado – we've confirmed the following:

  • Timor -> East Timor
  • Democratic Republic of Congo can be shortened to DR Congo when needed
  • Turkey: no change

@bastianherre
Copy link
Collaborator

Prompted by the discussion about the countries-regions dataset, I propose to change the names used for two historical states:

  • Eritrea and Ethiopia -> Ethiopia (former): this makes this case analogous to 'Sudan (former)', when South Sudan was still part of the country; and it makes clear that the data refers to one country, not two.
  • United Korea -> Korea: this switches to the commonly used historical name; and it yields more sensible Google search results for the unassuming user.

As opposed to some of the changes considered above, this likely affects few datasets.

@stale
Copy link

stale bot commented Apr 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 17, 2023
@edomt
Copy link
Contributor

edomt commented Apr 18, 2023

When we get to it, we should probably do Faeroe Islands -> Faroe Islands as well.

Our current spelling is technically acceptable but very rare:

image

@stale stale bot removed the wontfix This will not be worked on label Apr 18, 2023
@stale
Copy link

stale bot commented Jun 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 25, 2023
@stale stale bot closed this as completed Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 2 - important wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

10 participants