Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updated 'decimal.js' to v10.4.3 #159

Closed
wants to merge 1 commit into from

Conversation

TimShilov
Copy link

@TimShilov TimShilov commented Apr 11, 2024

Fixes: #158

I have updated minor version number since the new version must be updated together with decimal.js, otherwise it will still not work.

…-snapshots

Update snapshots to fix tests

chore(deps): updated 'decimal.js' to v10.4.3

chore: bumbed version number
@TimShilov TimShilov requested a review from a team as a code owner April 11, 2024 18:01
Copy link

jit-ci bot commented Apr 11, 2024

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@aug24
Copy link

aug24 commented Feb 5, 2025

Closed because very stale.

@aug24 aug24 closed this Feb 5, 2025
@TimShilov
Copy link
Author

@aug24 What do you mean by stale? This repo wasn't updated for 2 years, so this PR is still not behind and is still relevant. 🤷‍♂️

I have found an issue and made a fix for it. Maintaners haven't looked at it for almost a year, and now when you had time to look at it you decided to close it instead of merging and fixing a bug?
That doesn't sound like a reasonable move (unless you want people to stop using this package). 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avro-decimal does not work with latest version of decimal.js
3 participants