feat(helm): Make the secret to start the deployment mandatory and variabilize secret name #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the --watch-filter argument from kube-rbac-proxy container to manager one to be really applied Fix outscale#442
fix(helm): Fix watch-filter argument making pods crashing
…iabilize secret name
alistarle
changed the title
jfbus
reviewed
Feb 10, 2025
| @@ -36,9 +36,6 @@ spec: | |||
| - --upstream=http://127.0.0.1:8080/ | |||
| - --logtostderr=true | |||
| - --v={{ .verbosity }} | |||
| {{- if .watchFilter }} | |||
There was a problem hiding this comment.
A little creep from another PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It will prevent pod to start when the outscale credential secret is not found, and variabilize the secret name in values
Which issue(s) this PR fixes :
Fixes #444
TODOs: