Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Outscale secret should not be optionnal when starting the provider #444

Open
alistarle opened this issue Feb 10, 2025 · 0 comments · May be fixed by #445
Open

[Bug]: Outscale secret should not be optionnal when starting the provider #444

alistarle opened this issue Feb 10, 2025 · 0 comments · May be fixed by #445
Labels
bug Something isn't working

Comments

@alistarle
Copy link
Contributor

alistarle commented Feb 10, 2025

What happened

When installing the helm chart with default value, there is an issue when the secret credentials are not created before. Indeed, instead of waiting for the secret, the pod start without it and do nothing. We should prevent it to start so it will be functionnal just when the secret is created. I also suggest to variabilize the secret name in the helm values.

https://github.com/outscale/cluster-api-provider-outscale/blob/main/helm/clusterapioutscale/templates/deployment.yaml#L70

Step to reproduce

Do not create any secret who contains outscale credentials and install the helm chart with default value.

Expected to happen

The pods should wait for the credentials to be created in the cluster, otherwise the pod will silently fail and do not restart when the secret is created after. We can assume the controller will do nothing without credentials so I think it is acceptable to prevent it to start.

Add anything

I also suggest to variabilize the secret name who contains the outscale credentials

cluster-api output

Issue that the controller cannot find outscale credentials

Environment

- Kubernetes version: (use `kubectl version`): 
- OS (e.g. from `/etc/os-release`):
- Kernel (e.g. `uname -a`):
- cluster-api-provider-outscale version:
- cluster-api version: 
- Install tools:
- Kubernetes Distribution:
- Kubernetes Diestribution version:
@alistarle alistarle added the bug Something isn't working label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant