You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing the helm chart with default value, there is an issue when the secret credentials are not created before. Indeed, instead of waiting for the secret, the pod start without it and do nothing. We should prevent it to start so it will be functionnal just when the secret is created. I also suggest to variabilize the secret name in the helm values.
Do not create any secret who contains outscale credentials and install the helm chart with default value.
Expected to happen
The pods should wait for the credentials to be created in the cluster, otherwise the pod will silently fail and do not restart when the secret is created after. We can assume the controller will do nothing without credentials so I think it is acceptable to prevent it to start.
Add anything
I also suggest to variabilize the secret name who contains the outscale credentials
cluster-api output
Issue that the controller cannot find outscale credentials
What happened
When installing the helm chart with default value, there is an issue when the secret credentials are not created before. Indeed, instead of waiting for the secret, the pod start without it and do nothing. We should prevent it to start so it will be functionnal just when the secret is created. I also suggest to variabilize the secret name in the helm values.
https://github.com/outscale/cluster-api-provider-outscale/blob/main/helm/clusterapioutscale/templates/deployment.yaml#L70
Step to reproduce
Do not create any secret who contains outscale credentials and install the helm chart with default value.
Expected to happen
The pods should wait for the credentials to be created in the cluster, otherwise the pod will silently fail and do not restart when the secret is created after. We can assume the controller will do nothing without credentials so I think it is acceptable to prevent it to start.
Add anything
I also suggest to variabilize the secret name who contains the outscale credentials
cluster-api output
Issue that the controller cannot find outscale credentials
Environment
The text was updated successfully, but these errors were encountered: