From e74a555a5562dbd85a266c53d46d3d4eddd23d3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20B=C3=B8gh=20K=C3=B6ster?= Date: Thu, 29 Feb 2024 11:24:24 +0100 Subject: [PATCH] Remove SolrInfoBean interface --- .../InstrumentedHtttpShardHandlerFactory.java | 26 +++---------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/solr/core/src/java/org/apache/solr/handler/component/InstrumentedHtttpShardHandlerFactory.java b/solr/core/src/java/org/apache/solr/handler/component/InstrumentedHtttpShardHandlerFactory.java index 304a7702ada..73a59aef8d9 100644 --- a/solr/core/src/java/org/apache/solr/handler/component/InstrumentedHtttpShardHandlerFactory.java +++ b/solr/core/src/java/org/apache/solr/handler/component/InstrumentedHtttpShardHandlerFactory.java @@ -48,8 +48,7 @@ * *

This code uses reflection to break up closed internal APIs. */ -public class InstrumentedHtttpShardHandlerFactory extends HttpShardHandlerFactory - implements SolrInfoBean { +public class InstrumentedHtttpShardHandlerFactory extends HttpShardHandlerFactory { private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); @@ -100,7 +99,7 @@ void registerDeadServerMetricGauges() { () -> zombies.size(), true, "count", - Category.QUERY.name(), + SolrInfoBean.Category.QUERY.name(), "httpShardHandler", "zombieServers"); getSolrMetricsContext() @@ -108,7 +107,7 @@ void registerDeadServerMetricGauges() { () -> alives.size(), true, "count", - Category.QUERY.name(), + SolrInfoBean.Category.QUERY.name(), "httpShardHandler", "aliveServers"); @@ -182,7 +181,7 @@ void checkAvailableHttpDestinations(HttpClient httpClient) { destinationGauge, true, "count", - Category.QUERY.name(), + SolrInfoBean.Category.QUERY.name(), "httpShardHandler", "shardRequestQueue", destinationName); @@ -230,21 +229,4 @@ public Integer getValue() { } } } - - // SolrInfoMBean methods - - @Override - public String getName() { - return InstrumentedHtttpShardHandlerFactory.class.getName(); - } - - @Override - public String getDescription() { - return "A shard handler factory that captures Jetty http client metrics"; - } - - @Override - public Category getCategory() { - return Category.QUERY; - } }