Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.4-beta misses some settings. #180

Closed
noyannus opened this issue Apr 11, 2023 · 6 comments · Fixed by #187
Closed

v3.2.4-beta misses some settings. #180

noyannus opened this issue Apr 11, 2023 · 6 comments · Fixed by #187

Comments

@noyannus
Copy link
Contributor

v3.2.4-beta does not catch

  • toolbars in konsole,

  • tabbar and titlebar in yakuake

  • profile of dolphin's terminal pane.

No idea how to approach these. ((

Dolphin has no setProfile in qdbus org.kde.dolphin-$(pgrep dolphin -u $USER).

2023-04-11_11-04-05

2023-04-11_11-04-15

@l0drex
Copy link
Collaborator

l0drex commented Apr 17, 2023

Uhm, I do have a setProfile for dolphin. It's exactly where it is for yakuake and konsole, will add it in the next beta release.

Toolbars in Konsole should just be handled by the global theme (system plugin), but it looks like the icons are buggy in your screenshot.

Yakuake is a different story, but it doesn't have many themes (at least by default), so it's no priority for me. At first glance, I couldn't find a config file or dbus interface.

@l0drex l0drex linked a pull request Apr 17, 2023 that will close this issue
@l0drex
Copy link
Collaborator

l0drex commented Apr 17, 2023

Yakuake was requested in #113, so I will close this with the next release

@noyannus
Copy link
Contributor Author

Dolphin, that's strange. Must be a different system or installation.

$ qdbus org.kde.dolphin-30323 | grep profile
$ qdbus org.kde.konsole-26105 /Sessions/1 | grep profile
method Striking org.kde.konsole.Session.profile()
method void org.kde.konsole.Session.setProfile(QString profileName)

The Konsole toolbar issue may have been caused because I set the system them for light and dark both to Breeze (to keep the window decorations) and set the others via the other plugins and script. I'll wait for the next release to see if that's still necessary.

@l0drex
Copy link
Collaborator

l0drex commented Apr 18, 2023

I'm using Dolphin version 22.12.3, Konsole the same.

@noyannus
Copy link
Contributor Author

Same versions here.

Konsole toolbar: @adrium has the solution in nightadjuster. The window color profiles need their own setting loop.

@l0drex
Copy link
Collaborator

l0drex commented Apr 28, 2023

Dolphin only has the session path if the Konsole panel is actually opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants