Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: softhsm package should be softhsm2? #3916

Open
3 of 5 tasks
polarathene opened this issue Jan 5, 2025 · 1 comment
Open
3 of 5 tasks

bug: softhsm package should be softhsm2? #3916

polarathene opened this issue Jan 5, 2025 · 1 comment
Labels
bug Something is not working.

Comments

@polarathene
Copy link

Preflight checklist

Ory Network Project

No response

Describe the bug

The Github Actions CI and Dockerfiles seem to rely on softhsm as a package for the HSM tests.

In a PR I recently opened this was a failure as the package could not be found. The version of Ubuntu is not pinned, although I'm not sure why the failure wasn't caught prior to my PR as my PR has nothing to do with that CI workflow AFAIK?

The Docker images use Debian as a base where softhsm is still a valid package name, there's also softhsm2 there and the softhsm debian package does bring in softhsm2 implicitly.

The last version of Ubuntu with the softhsm package appears to be 16.04. Github Actions test runner is using ubuntu-latest. All newer versions of Ubuntu pacakge that binary in the softhsm2 package.

Reproducing the bug

Both Ubuntu and Debian have a softhsm2 package, only Debian has the softhsm pacakge (brings in softhsm2). Should be resolved and consistent with all package installs preferring the softhsm2 package instead.


Ubuntu failure:

$ docker run --rm -it -e DEBIAN_FRONTEND=noninteractive ubuntu:24.04 bash -c 'apt-get -qq update && apt-get -qq install -y softhsm'

E: Unable to locate package softhsm

Ubuntu success by using softhsm2 instead of softhsm:

$ docker run --rm -it -e DEBIAN_FRONTEND=noninteractive ubuntu:24.04 bash -c 'apt-get -qq update && apt-get -qq install -y softhsm2'

Creating config file /etc/softhsm/softhsm2.conf with new version
Setting up libsofthsm2 (2.6.1-2.2ubuntu3) ...
Setting up softhsm2 (2.6.1-2.2ubuntu3) ...

Debian success with softhsm or softhsm2:

$ docker run --rm -it -e DEBIAN_FRONTEND=noninteractive debian:bookworm-slim bash -c 'apt-get -qq update && apt-get -qq install -y softhsm'

# ...

Creating config file /etc/softhsm/softhsm2.conf with new version
Setting up libsofthsm2 (2.6.1-2.1) ...
Setting up softhsm2 (2.6.1-2.1) ...
Setting up softhsm (2.6.1-2.1) ...
$ docker run --rm -it -e DEBIAN_FRONTEND=noninteractive debian:bookworm-slim bash -c 'apt-get -qq update && apt-get -qq install -y softhsm2'

# ...

Creating config file /etc/softhsm/softhsm2.conf with new version
Setting up libsofthsm2 (2.6.1-2.1) ...
Setting up softhsm2 (2.6.1-2.1) ...

Relevant log output

See above reproduction output or while available, [this CI run failure](https://github.com/ory/hydra/actions/runs/12523819546/job/34933781514?pr=3914).

Relevant configuration

No response

Version

2.2.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

Originally investigated in this PR due to CI failure.

@polarathene polarathene added the bug Something is not working. label Jan 5, 2025
@aeneasr
Copy link
Member

aeneasr commented Jan 7, 2025

Happy to switch to softhsm2 if it keeps working in the tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants