Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): make sure responseDataType is not empty #1827

Merged

Conversation

AllieJonsson
Copy link
Contributor

Status

READY

Description

Fixes #1826

melloware
melloware previously approved these changes Jan 16, 2025
@melloware melloware requested a review from soartec-lab January 16, 2025 12:27
@melloware melloware added the fetch Fetch client related issue label Jan 16, 2025
@soartec-lab
Copy link
Member

I will check later 👍

Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllieJonsson
Thanks for handling this. And I added one suggestion.

packages/fetch/src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soartec-lab soartec-lab merged commit c091a0a into orval-labs:master Jan 23, 2025
2 checks passed
@soartec-lab soartec-lab added the bug Something isn't working label Jan 23, 2025
@soartec-lab soartec-lab added this to the 7.4.2 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fetch Fetch client related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response type missing when using Fetch with empty schema
3 participants