Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading Spatial-Module.md #88

Closed
smolinari opened this issue Dec 10, 2015 · 5 comments
Closed

Proofreading Spatial-Module.md #88

smolinari opened this issue Dec 10, 2015 · 5 comments
Assignees

Comments

@smolinari
Copy link
Contributor

This sounds like a really cool feature.

However, I have two possible issues with this doc page though.


  • Shouldn't it be a standard in the docs, that all SQL be full-caps?

Like

insert into TestLineSTring set name = 'Test1' , location = St_GeomFromText("LINESTRING(0 0, 3 3)")

should be

INSERT INTO TestLineSTring SET name = 'Test1' , location = St_GeomFromText("LINESTRING(0 0, 3 3)")


  • The function explanations are a bit confusing.

image

It took me a moment to realize, the information under the example is the result.

Wouldn't it be better to just say "Result"?

https://smolinari.gitbooks.io/orientdb-documentation/content/v/57961cdfcdaf42e0bbb9d8517c89977a578befae/Spatial-Module.html

I've made the changes. Hope that was also correct.

Scott

@kennethpjdyer
Copy link
Contributor

You're right. Revisions are already under way to fix SQL syntax, console displays, and various markup and consistency issues throughout the text. That's just a page that hasn't been covered yet.

New style deals with the 'results' problem.

@smolinari
Copy link
Contributor Author

Ah. Hmm... ok. I didn't know that was happening and didn't know things were being "standardized". That is cool! 👍

How about a "docs standards and procedures" page in the contribution section? So, anyone contributing can follow them?

Scott

@smolinari
Copy link
Contributor Author

Oh, can we also have the rule I started, that if someone proofread a page (and set it to the standards), they add an html comment like follows.

<!-- proofread 2015-12-10 XXX -->

where "XXX" are the initials of the person who did the proofreading? That way, if the page is fairly up-to-date, then there aren't people doing unnecessary double work.

Scott

@lvca
Copy link
Member

lvca commented Dec 10, 2015

+1 for the proofread idea

@lvca lvca self-assigned this Dec 10, 2015
@smolinari
Copy link
Contributor Author

Closing this. I've started a new topic about standardization and procedures for the docs. #90

Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants