Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Allow bulk selection for notebooks #810

Open
rieje opened this issue Jan 23, 2021 · 5 comments
Open

[Feature request] Allow bulk selection for notebooks #810

rieje opened this issue Jan 23, 2021 · 5 comments

Comments

@rieje
Copy link

rieje commented Jan 23, 2021

Just a simple feature request: allow bulk selection of notebooks to perform actions like deleting in one go. At the moment, selecting a notebook allows some options such as overwriting local/remote notebook, exporting, renaming, and deleting.

If user chooses to do a bulk selection, at least allow the option to delete the notebooks. Other actions like bulk renaming notebooks may not be as appropriate,

My use-case is I use Syncthing to sync my notes periodically. Occasionally, there are conflicts and conflict files will automatically be created on my phone and these files get synced to my machines. If I just delete the conflicting files on my machines, they aren't deleted in Orgzly so it re-syncs them back to my machine. As a result, I must delete these conflicting notebooks manually on Orgzly and it's a big pain to delete them manually one by one.

@JimBreton
Copy link

JimBreton commented Jan 23, 2021

Just curious, what conditions do you find cause most of your conflicts?

I've found that I greatly reduced the incidence of conflicts by setting Syncthing's Fs Watcher Delay setting (in "Advanced") to 5 seconds (default is 10). Doesn't seem like a big change but made a huge difference.

Also using 'global-auto-revert-mode' in Emacs has reduced the probability of writing to the shared file without realizing something on disk had already been changed by some other process. Between these two changes I hardly ever get conflicts anymore.

@makuto
Copy link

makuto commented Jan 26, 2021

I also have problems using Syncthing and Orgzly. The most common way I hit it is as follows:

  • Phone has system update, requiring a restart
  • Upon restart, Syncthing doesn't auto-startup
  • I make changes to a file I've previously edited on my PC, not realizing Syncthing isn't running
  • I curse once I realize what I've done, and start up Syncthing to avoid spreading the problem
  • Sync conflict is then synced to the 3+ devices running Orgzly (phone, tablet, and e-reader). To remove the conflict, I must get all three devices together, disable syncthing, delete the conflict, delete the conflict on my PC, then re-enable syncthing on all devices

I think a better solution may be to ignore *.sync-conflict* files in Orgzly. This could be implemented as a "file exclusion filter" so it would be useful for any similar problems.

If it is still useful to you to see the sync conflict files in Orgzly (I prefer to handle all diff resolution on my PC, because there's no good Diff programs on Android afaik), then the exclude filter could become more nuanced: If the file matching the filter no longer exists, delete the notebook automatically.

Another solution would be "Do not auto-create missing notebooks in remote repository". This would still require you to delete the notebooks after resolving the conflict, but at least the conflict won't keep propagating across devices.

@makuto
Copy link

makuto commented Jan 26, 2021

A more heavy-handed option would be "Delete notebooks which no longer exist in remote repository".

This is potentially destructive, so it may require some additional safety backups and user warnings. Optionally, it could be a separate "Archive" group of notebooks that it would move the now deleted sync conflicts to.

@makuto
Copy link

makuto commented Jan 26, 2021

Related issue which may solve this one: #287

@rieje
Copy link
Author

rieje commented May 8, 2021

My conflicts are the result of using Tasker to run Syncthing periodically (every hour or so) for 60 seconds (enough for syncing my files, which are mostly text and pictures). So within the window between syncs, I get conflicts if I changed something both on the phone and on the computer. So I guess my issue is mostly avoidable by syncing even more frequently. I don't have Syncthing running as a background service 24/7 to maximize battery life.

Bulk selection already exists in some form with the app, so I feel like extending it to notebooks seems like an obvious choice. I will have to follow the issues involving other ways Syncthing conflicts occur that you guys mentioned that has also been my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants