Can I add a little bit more concrete examples to the pull request guideline? #2580
-
Can I add a bit more concrete examples for the case of creating a larger pull request? Current oneThe current pull request guideline says If your pull request is a large change not covered by the examples above, discuss with the maintainers before submission. Doing so ensures that the proposed change is in line with Autoware's design philosophy and current development plans. If you're not sure where to have that conversation, then create a new Q&A discussion. My proposalMy proposal update is to add concrete examples like below: If your pull request is a large change such as
not covered by the examples above, discuss with the maintainers before submission. Doing so ensures that the proposed change is in line with Autoware's design philosophy and current development plans. If you're not sure where to have that conversation, then create a new Q&A discussion. |
Beta Was this translation helpful? Give feedback.
Replies: 0 comments 2 replies
-
@IshitaTakeshi cc @LalithVipulananthan LGTM. Please submit a PR! 👍 |
Beta Was this translation helpful? Give feedback.
@IshitaTakeshi cc @LalithVipulananthan LGTM. Please submit a PR! 👍