playlist-first playback flow + autoqueue files in directory #23
Conversation
There was a problem hiding this comment.
Thanks for the PR.
will change this to use GetFileType later
Just using the extension should be fine, although it probably should ensure that the filename selected is always added to the playback queue and is the initial file selected.
"playlist file" code to be tentatively removed (m3u files do the same stuff, right?)
The json playlist file stuff was more of a debugging thing for netradio before m3u and pls was supported (with ParseNC() being parse netradio config iirc). That said, I don't see the need to comment it out as the fix is pretty trivial.
Displaying the full filepath isn't great, as only the file name is important (especially since I don't have text scrolling atm), which is what playbackInfo->filename was for. Not sure if you have something different in mind, I'll have to think about how best to handle it later.
Overall, good work.
MIDI formats, okay!
Already planned to restore this after making sure my playlist shotgun-implementation worked. I preserved the filepath field as
Planned too Thanks for your review! |
I personally can't wrap my head around how the playlist in |
Firepal
force-pushed
the
playlist_basic
branch
2 times, most recently
from
33caa3d to
eed9a39
Compare
Firepal
force-pushed
the
playlist_basic
branch
from
eed9a39 to
df25669
Compare
|
Alright. I think I'm happy with the current state of this PR. |
Firepal
force-pushed
the
playlist_basic
branch
3 times, most recently
from
49c29ed to
e15f6aa
Compare
src/gui/menus/PlayerMenu.cpp
Outdated
| // if we don't support the file, we won't go any further | ||
| // to prevent unnecessarily stopping the music | ||
| std::string extension = filepath.substr(filepath.find_last_of('.') + 1); | ||
| if (!is_extension_supported(extension)) |
There was a problem hiding this comment.
This should not be done for playlist files and m3u, pls, and json should not be in SUPPORTED_EXTS.
The playlist field in settings_t was completely unused originally with the idea that it was something that I would implement later, I'll probably remove it entirely. |
|
I'm not sure I understand what exactly the problem is with having the playlist extensions in the supported extension list. |
Firepal
force-pushed
the
playlist_basic
branch
3 times, most recently
from
e15f6aa to
1a7a6e6
Compare
|
I think I got it |
filepathfield is replaced by an index into the playlist. inspired by VLC's behaviorfixes #22