Encrypted wallet support

[cartosquare]

Problem

Bitcoin Core wallet supports encrypting wallets using passphrase, since ord use it's rpc interface, do you guys think it's a good idea to also support this in ord? To achive this, we need to add an addition optional parameter(for example: password) to wallet create subcommand.

Pro

• It will maintain ord wallet's security even when wallet file is leaked.

Con

• When wallet is encryped, before doing any signing related operations(such as inscribe, etching, send, etc), we need to use bitcoin-cli walletpassphrase command to unlock wallet for some limited time.

[so7ow]

 $ ord wallet create --help
Create new wallet

Usage: ord wallet create [OPTIONS]

Options:
      --passphrase <PASSPHRASE>  Use <PASSPHRASE> to derive wallet seed. [default: ]
  -h, --help                     Print help

 $ ord wallet restore --help
Restore wallet

Usage: ord wallet restore [OPTIONS] --from <FROM>

Options:
      --from <FROM>              Restore wallet from <SOURCE> on stdin. [possible values: descriptor, mnemonic]
      --passphrase <PASSPHRASE>  Use <PASSPHRASE> when deriving wallet.
      --timestamp <TIMESTAMP>    Scan chain from <TIMESTAMP> onwards. Can be a unix timestamp in seconds or the string `now`, to skip scanning
  -h, --help                     Print help

[cartosquare]

 $ ord wallet create --help
Create new wallet

Usage: ord wallet create [OPTIONS]

Options:
      --passphrase <PASSPHRASE>  Use <PASSPHRASE> to derive wallet seed. [default: ]
  -h, --help                     Print help

This passphrase is used to derive wallet seed, not encrypt wallet?

bitcoin rpc api: createwallet

[so7ow]

encrypt wallet?

Well, we might have a terminology mismatch here. You invoked bitcoin-cli walletpassphrase so I thought you were looking for wallet passphrase functionality in ord. If you really want to encrypt the wallet file (on disk, presumably?) you might be barking up the wrong tree, as bitcoin manages the wallet file, not ord.