Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests for decoding edicts #4122

Open
Th0rgal opened this issue Dec 10, 2024 · 1 comment
Open

Missing tests for decoding edicts #4122

Th0rgal opened this issue Dec 10, 2024 · 1 comment

Comments

@Th0rgal
Copy link
Contributor

Th0rgal commented Dec 10, 2024

Hello,

Our team is currently developing a Runes client in Cairo, enabling StarkNet to verify Runes. We have reimplemented the tests, and most of the OP_RETURN parsing into Runestones appears to be functioning correctly. However, we are encountering issues with Edicts: we are not detecting transfers where Hiro’s API does. Although we have implemented tests for these cases, it seems that there may be missing tests specific to Edicts or we might have overlooked them.

Could you please let us know if there are additional tests related to Edicts or guide us to the appropriate resources? This would greatly help us move forward.

Thanks,
Thomas

@raphjaph
Copy link
Collaborator

Have a look at the ordinals crate: https://github.com/ordinals/ord/tree/master/crates/ordinals/src

Specifically src/runestone.rs has a bunch of tests.

That crate should have nice type you can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants