Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs tests #4

Open
stuartpb opened this issue Nov 15, 2017 · 0 comments
Open

Needs tests #4

stuartpb opened this issue Nov 15, 2017 · 0 comments

Comments

@stuartpb
Copy link
Member

Just realized that I never actually put a non-zero condition on validation failure, so my CI tests have all been coming back green even when my PRs are invalid.

This is the kind of thing that would have been caught by tests.
stuartpb added a commit that referenced this issue Nov 15, 2017
@stuartpb
Exit 1 when there are validation failures
ee2116c 
As noted in #4, I forgot to do this. 🤦
@stuartpb stuartpb mentioned this issue Nov 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartpb