Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing examples #23

Open
stuartpb opened this issue Nov 15, 2017 · 2 comments
Open

Testing examples #23

stuartpb opened this issue Nov 15, 2017 · 2 comments
Labels

Comments

@stuartpb
Copy link
Member

I just checked and I'm pretty sure the examples listed for v0.1 and v0.2 are invalid.

While the fixes involved to address this should be minor, the fact remains that each schema should be tested against its example profiles / legacies.

@stuartpb stuartpb added the ci label Nov 15, 2017
@stuartpb
Copy link
Member Author

#24 hits another kind of example that isn't tested against - the excerpts in Markdown documentation. I'm not sure how to structure these to be testable without being way too invasive about YAML blocks in documentation, but it's something to consider.

@stuartpb
Copy link
Member Author

stuartpb commented Sep 17, 2018

As an example of the kind of thing that would be caught by these tests, https://github.com/opws/opws-schemata/blob/82799027df007c5d0002aecb11762de891eeac3d/v0.2/examples/exhaustive.yaml has a root "terms" object for what would now go under legal.documents.

I'm going to hold off on filing issues for these kinds of discrepancies, in favor of this one that will catch all these issues once implemented (though, TBH, I should just be making fixes as I notice them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant