Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 ANSI color in console output 💡 #38

Closed
adriens opened this issue Mar 16, 2022 · 16 comments
Closed

💡 ANSI color in console output 💡 #38

adriens opened this issue Mar 16, 2022 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@adriens
Copy link
Member

adriens commented Mar 16, 2022

In the log outuput it would be cool to get the log output colorized according to the lint/fix status :

  • green : nothing had to be done
  • orange : fixes have been done
  • red : lint did not pass and no fix could be applied : human intervention required
@adriens adriens added the enhancement New feature or request label Mar 16, 2022
@tamere-allo-peter
Copy link
Member

colorsummary

@adriens
Copy link
Member Author

adriens commented Mar 16, 2022

Hello beauty 💟

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

You mean .... you have released it ❔ ❣️

@tamere-allo-peter
Copy link
Member

It seems to be the case :)

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

🎅

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

Seems like I can't see the colors on Katacoda :

image

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

Whereas I can get colors while using other command line tools

@tamere-allo-peter
Copy link
Member

@adriens : try again with --colorsummary

@tamere-allo-peter
Copy link
Member

@adriens it might become the default with --summary and have --colorsummary disappear, not sure yet...

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

image

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

@adriens it might become the default with --summary and have --colorsummary disappear, not sure yet...

I would keep only --summary ... which would reply with colors (that's what I would expect)

@tamere-allo-peter
Copy link
Member

Yeah you're probably right...

@tamere-allo-peter
Copy link
Member

BTW the current implementation doesn't works as you might expect, since if no fix could be done the file is considered as SKIPPED, which is different from the red ERROR status (mostly write permissions problem).

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

I'm performing tests on Windows cf #41 ...

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

Surprinsigl it works on windows DOS command... but not on gith bash cf #43

@adriens
Copy link
Member Author

adriens commented Mar 17, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants