Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ViewpointAdapter and DependentTypes #72

Open
jyluo opened this issue Aug 1, 2018 · 4 comments
Open

Integrate ViewpointAdapter and DependentTypes #72

jyluo opened this issue Aug 1, 2018 · 4 comments

Comments

@jyluo
Copy link

jyluo commented Aug 1, 2018

to keep opprop/CF in sync and not diverge from typetools/CF

@wmdietl
Copy link
Member

wmdietl commented Sep 1, 2018

The steps we wanted to follow before doing this are documented here:
#69 (review)

@jyluo
Copy link
Author

jyluo commented Sep 3, 2018

The review notes say

  1. raise dependent types to ATF level from GenericATF 2)Merge the two functionalities

I'm unclear on what "dependent types" here refer to.

@wmdietl
Copy link
Member

wmdietl commented Sep 3, 2018

https://github.com/typetools/checker-framework/blob/master/framework/src/main/java/org/checkerframework/framework/util/dependenttypes/DependentTypesTreeAnnotator.java
and other classes in that package.
Viewpoint adaptation and what is called "dependent types" here have similar functionality.
Currently a lot of this is duplicated. This should be unified into one nice implementation.

@wmdietl
Copy link
Member

wmdietl commented Jun 21, 2022

eisop#266 integrates the ViewpointAdapter with eisop.
Further integration would still be good to simplify the code.

@wmdietl wmdietl changed the title Push Viewpoint adaptor CF changes to typetools Integrate ViewpointAdapter and DependentTypes Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants