From aabebae12e462d07daf72d5d082b14e5931f6ea2 Mon Sep 17 00:00:00 2001
From: Reiner030 <Reiner030@gmx.net>
Date: Sat, 29 Jun 2024 19:50:35 +0200
Subject: [PATCH] OpenVPN: Wrong RADIUS_NAS_PORT_TYPE implementation value
 Ethernet instead Virtual #7583

---
 src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php b/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php
index f8be7de0376..fbfd0d90056 100644
--- a/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php
+++ b/src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php
@@ -214,7 +214,7 @@ public function startAccounting($username, $sessionid)
                 $error = radius_strerror($radius);
             } elseif (!radius_put_int($radius, RADIUS_NAS_PORT, 0)) {
                 $error = radius_strerror($radius);
-            } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_ETHERNET)) {
+            } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_VIRTUAL)) {
                 $error = radius_strerror($radius);
             } elseif (!radius_put_string($radius, RADIUS_USER_NAME, $username)) {
                 $error = radius_strerror($radius);
@@ -282,7 +282,7 @@ public function stopAccounting($username, $sessionid, $session_time, $bytes_in,
                 $error = radius_strerror($radius);
             } elseif (!radius_put_int($radius, RADIUS_NAS_PORT, 0)) {
                 $error = radius_strerror($radius);
-            } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_ETHERNET)) {
+            } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_VIRTUAL)) {
                 $error = radius_strerror($radius);
             } elseif (!radius_put_string($radius, RADIUS_USER_NAME, $username)) {
                 $error = radius_strerror($radius);
@@ -363,7 +363,7 @@ public function updateAccounting($username, $sessionid, $session_time, $bytes_in
                 $error = radius_strerror($radius);
             } elseif (!radius_put_int($radius, RADIUS_NAS_PORT, 0)) {
                 $error = radius_strerror($radius);
-            } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_ETHERNET)) {
+            } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_VIRTUAL)) {
                 $error = radius_strerror($radius);
             } elseif (!radius_put_string($radius, RADIUS_USER_NAME, $username)) {
                 $error = radius_strerror($radius);
@@ -437,7 +437,7 @@ public function authenticate($username, $password)
             $error = radius_strerror($radius);
         } elseif (!radius_put_int($radius, RADIUS_NAS_PORT, 0)) {
             $error = radius_strerror($radius);
-        } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_ETHERNET)) {
+        } elseif (!radius_put_int($radius, RADIUS_NAS_PORT_TYPE, RADIUS_VIRTUAL)) {
             $error = radius_strerror($radius);
         } else {
             // Implement extra protocols in this section.