Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix nodepool e2e test #2283

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

tnsimon
Copy link
Contributor

@tnsimon tnsimon commented Jan 31, 2025

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Fixes the nodepool e2e test which is currently commented out

Which issue(s) this PR fixes:

Fixes #2282

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

no

other Note

In the e2e test, worker2 is not assigned to anything; we instead evaluate 2 scenarios:

  1. Create an empty nodepool without nodes then delete it (this is allowed as the webhook won't return validation error).
  2. Create a nodepool with worker2 (currently unmapped). Assert it became ready in the nodepool. We don't delete this as there's no simple way to recreate it in the kind cluster (for now).

@tnsimon tnsimon requested a review from a team as a code owner January 31, 2025 04:17
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.40%. Comparing base (d690808) to head (c1278de).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2283   +/-   ##
=======================================
  Coverage   46.39%   46.40%           
=======================================
  Files         416      416           
  Lines       27266    27266           
=======================================
+ Hits        12651    12653    +2     
+ Misses      13335    13333    -2     
  Partials     1280     1280           
Flag Coverage Δ
unittests 46.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 3, 2025

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Feb 3, 2025
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit 887a02e into openyurtio:master Feb 3, 2025
14 checks passed
@tnsimon tnsimon deleted the fix-nodepool-e2e branch February 3, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Nodepool e2e Test
2 participants