Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add pod request into reconcile queue instead of node #2245

Merged

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

improve pod binding controller as following:

  1. only process edge nodes and pods which run on edge nodes.
  2. add pod request into reconcile queue instead of adding node request.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@rambohe-ch rambohe-ch requested a review from a team as a code owner January 6, 2025 05:32
@rambohe-ch rambohe-ch force-pushed the fix-pod-binding-controller branch from cf4fb1f to 6224874 Compare January 6, 2025 07:48
Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.18%. Comparing base (290d189) to head (6224874).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...rtcoordinator/podbinding/pod_binding_controller.go 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   45.19%   45.18%   -0.02%     
==========================================
  Files         422      422              
  Lines       28778    28783       +5     
==========================================
- Hits        13007    13006       -1     
- Misses      14463    14468       +5     
- Partials     1308     1309       +1     
Flag Coverage Δ
unittests 45.18% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyjhtangtang
Copy link
Contributor

/LGTM

@zyjhtangtang zyjhtangtang merged commit 3217403 into openyurtio:master Jan 6, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants